test: use T.TempDir to create temporary test directory
#817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <[email protected]>
This commit fixes the 3 failing tests on Windows [1] 1. TestEncryptDecryptFilePadding 2. TestEncryptDecryptLargeFile 3. TestPutGetFile They all failed with the same reason: testing.go:1097: TempDir RemoveAll cleanup: remove ... The process cannot access the file because it is being used by another process. Windows handle open files differently [2] so we need to close all open file descriptors explicitly. [1]: https://github.com/snowflakedb/gosnowflake/actions/runs/5214296899/jobs/9410395563?pr=647 [2]: golang/go#50510 (comment) Signed-off-by: Eng Zer Jun <[email protected]>
Reference: https://github.com/snowflakedb/gosnowflake/pull/647/files#r1233553225 Signed-off-by: Eng Zer Jun <[email protected]>
sfc-gh-pfus
force-pushed
the
test_pr_647
branch
from
c8152f3 to
62fc5c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
=======================================
Coverage 83.23% 83.24%
=======================================
Files 49 49
Lines 9287 9290 +3
=======================================
+ Hits 7730 7733 +3
Misses 1557 1557
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Closing as merged original PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces
ioutil.TempDirwitht.TempDirin tests. The directory created byt.TempDiris automatically removed when the test and all its subtests complete.Prior to this commit, temporary directory created using
ioutil.TempDirneeds to be removed manually by callingos.RemoveAll, which is omitted in some tests. The error handling boilerplate e.g.defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but
t.TempDirhandles this for us nicely.Reference: https://pkg.go.dev/testing#T.TempDir
Description
Please explain the changes you made here.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them