SNOW-1855886 gracefully ignore when default region us-west-2 is used in DSN or NewConnector #1278
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in DSN or NewConnector
sfc-gh-pfus
approved these changes
Dec 16, 2024
dsn_test.go
Outdated
| User: "u", | ||
| Password: "p", | ||
| Account: "account", | ||
| Host: "account.us-west-2.snowflakecomputing.com", |
There was a problem hiding this comment.
we support also account.us-west-2.aws - there also dsn should be shortened?
There was a problem hiding this comment.
then the next question is that we should correct every notation in every driver, which i agree is the ideal final goal
There was a problem hiding this comment.
added SNOW-1858448 to track the more comprehensive effort
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1278 +/- ##
==========================================
- Coverage 82.21% 82.20% -0.02%
==========================================
Files 55 55
Lines 13537 13547 +10
==========================================
+ Hits 11130 11136 +6
- Misses 2407 2411 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
us-west-2region is the default region in Snowflake, and a special one. We already had checks for the case where someone accidentally configures it inRegion, but forAccountwe did not have any, which led to anAccount(mis)configured asmyaccount.us-west-2instead of omitting the region (as is the default) and usingmyaccount, not being able to connect to Snowflake and instead failing with HTTP404.This change attempts to step over such simple misconfiguration gracefully and
.us-west-2from Account instead of allowing the connection to proceed, which then surely will fail on the Snowflake backendChecklist