SNOW-1856499 Separate GCS transport from the standard one #1274
Conversation
sfc-gh-pfus
force-pushed
the
tmp-gcs-head-testing
branch
4 times, most recently
from
841f755 to
c2d88a0
Compare
sfc-gh-pfus
force-pushed
the
tmp-gcs-head-testing
branch
from
c2d88a0 to
ecb5dc9
Compare
![semgrep-app-snowflakedb[bot]](https://avatars.githubusercontent.com/u/6453780?s=60&v=4){kind=small}
gcs_storage_client.go
Outdated
| TLSClientConfig: &tls.Config{ | ||
| RootCAs: certPool, | ||
| VerifyPeerCertificate: verifyPeerCertificateSerial, | ||
| }, |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
MinVersion is missing from this TLS configuration. By default, TLS 1.2 is currently used as the minimum when acting as a client, and TLS 1.0 when acting as a server. General purpose web applications should default to TLS 1.3 with all other protocols disabled. Only where it is known that a web server must support legacy clients with unsupported an insecure browsers (such as Internet Explorer 10), it may be necessary to enable TLS 1.0 to provide support. Add `MinVersion: tls.VersionTLS13' to the TLS configuration to bump the minimum version to TLS 1.3.
To resolve this comment:
No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Leave a nosemgrep comment directly above or at the end of line 407 like so // nosemgrep: go.lang.security.audit.crypto.missing-ssl-minversion.missing-ssl-minversion
Take care to validate that this is not a true positive finding before ignoring it.
Learn more about ignoring code, files and folders here.
You can view more details about this finding in the Semgrep AppSec Platform.
sfc-gh-pfus
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1274 +/- ##
==========================================
- Coverage 82.20% 82.19% -0.02%
==========================================
Files 55 55
Lines 13484 13484
==========================================
- Hits 11085 11083 -2
- Misses 2399 2401 +2 ☔ View full report in Codecov by Sentry. |
sfc-gh-pfus
changed the title
Description
Using the same HTTP pool caused problems on Windows.