Automate make assets #38
Conversation
scripts/tag_release_manually.sh
Outdated
| make assets | ||
|
|
||
| echo -e "${GREEN}Commit assets >> git commit -m 'fix: re-generate assets'${NC}" | ||
| git add pkg/template/assets_vfsdata.go |
There was a problem hiding this comment.
You probably need to check that make assets actually modified anything…
There was a problem hiding this comment.
Actually, maybe it would be better to just check if there are any changes due to make assets and exit the script if they are to let the user handle things because automatic commit and push from git is dangerous (for example, what happens if there is no origin master? Or if origin doesn't point to what we think it does?) 😄
What do you think @aureamunoz?
There was a problem hiding this comment.
Yes, true. Less cases to take in account for something that is not hard to do manually
RELEASE.md
Outdated
| @@ -6,15 +6,15 @@ Simply create a release using the script `./script/tag_release_manually.sh` wher | |||
| `ID` of the release to be created : | |||
|
|
|||
| ```bash | |||
| ./script/tag_release_manually.sh GITHUB_API_TOKEN VERSION | |||
| ./scripts/tag_release_manually.sh GITHUB_API_TOKEN VERSION | |||
There was a problem hiding this comment.
Have you checked if other code is not impacted by that change? I would have rather preferred that change in a different PR since it's not really related to what you're trying to accomplish here…
|
So, what do we do then ? |
scripts/tag_release_manually.sh
Outdated
| then | ||
| DIFF_FILES="$(git diff-files --ignore-submodules)" | ||
| if [[ $DIFF_FILES == *"pkg/template/assets_vfsdata.go"* ]]; then | ||
| echo >&2 "cannot $1: you have assets unstaged changes." |
… for checking if there are assets to commit/push on origin master
aureamunoz
force-pushed
the
automate-make-assets
branch
from
ae932b4 to
ef38d44
Compare
|
I've tried to simplify and clean the function doing the check about assets and add a comment in the doc to be clearer. WDYT @metacosm ? |
As we talked I have add a task for doing the
make assetsand commit/push the files during the release