Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/issue778 using Rf_error() #780

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Fix/issue778 using Rf_error() #780

merged 3 commits into from
Nov 22, 2024

Conversation

sneumann
Copy link
Owner

No description provided.

@sneumann sneumann requested a review from jorainer November 20, 2024 17:32
@jorainer
Copy link
Collaborator

Thanks @sneumann for looking into this! I checked also locally using the current Bioconductor devel container, but there seem to be more C++ errors now - also in other places. I will check and push to this branch.

jorainer
jorainer approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@jorainer jorainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steffen! Locally (using the Bioconductor devel docker image) R CMD check completes without warnings or errors, so should be good to go.

@sneumann sneumann merged commit 074cf83 into devel Nov 22, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorainer jorainer jorainer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sneumann @jorainer