addition of chromPeaksId to matchLamaChromPeaks() output
#773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorainer
approved these changes
Oct 3, 2024
jorainer
approved these changes
Oct 4, 2024
|
Looks good to me, too. Whichever PR gets merged first, the other needs to use a version |
|
OK, then I'll merge this into devel and update my branch/PR with this and change the version there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a small change to the
matchLamaChromPeaks()and its helper function which now means that the output of the match between the anchor peaks and the chromPeaks has an extra column called chromPeaksId.First time I make a small update like this, should I still bump the version ? Or you want to do that and mention this change in a next big update ?
PS: The number of commits in this PR is due to a previous project I was working on, on this branch. It's been removed.