-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import methods #746
Import methods #746
Conversation
The code is great, but I just think we need to re-evaluate the whole text import/export thing and design the methods and the whole process better - so that it is future proof and we can support other Spectra backends etc later. |
refactor: add storeResults/loadResults for Spectra etc
- method for spectra and MsBackend
@jorainer so here is the updated code with method to store and load MsBackendMzR and Spectra objects. The checks passes ! It seems much more sturdy, thanks a lot for the helps to re-structure. I wanted you to check what it looks like now but there are still some things that needs to be discussed:
(if you see that i changed random .R files, i just fixed some dependencies) |
thanks @philouail ! I'll check/evaluate your branch locally and eventually make some changes/requests to that. |
- Small fixes and formatting changes in the code. - Expand unit tests to cover additional scenarios. - Update/restructure documentation.
refactor: updates of documentation and extension of unit tests
The only thing we might need to check before making this an official PR is to re-evaluate the names of the methods - if we want to change them it would be better to already start fixing them here. |
After a dev call with Laurent - we agreed that it might eventually be better to implement and test the import/export functionality in a separate package |
Closing because the code will be moved to a separate package. See MsIO. |
Here are the implementation of the generics function
loadResults()
and its respective method for the parameters RDataParam and PlainTextParam.I still have bugs in order to build examples/unit test with the spectra files path, I need some help regarding that.
PS: the github checks crash because of the new Spectra functions i added to the namespace (e.g
dataStorageBasePath
,dataStorageBasePath<-
).