Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of MzTabParam for export in .mztab format #718

Closed
wants to merge 12 commits into from
Closed

Conversation

philouail
Copy link
Collaborator

Here is the PR for the implementation of mztab-m export using the storeResults generic function combined with a param object of class MzTabParam .

For now, the export format only has the mandatory field available (as well as possibility to add opt_ columns for the SMF table.
In the future more metadata rows could be implemented if it makes sense from the format of XcmsExperiment object.

Any feedback and correction is welcomed.

@philouail philouail requested a review from jorainer February 2, 2024 09:29
@sneumann
Copy link
Owner

sneumann commented Feb 2, 2024

Hi, thanks for that PR!

Yours, Steffen

@philouail philouail changed the title Phili Addition of MzTabParam for export in .mztab format Feb 5, 2024
@philouail philouail marked this pull request as draft February 6, 2024 15:15
@jorainer
Copy link
Collaborator

jorainer commented Oct 2, 2024

So - the update of this PR was to remove all the mzTab related things now and just have a fix for the LamaParama? I would then suggest to maybe close this PR and open a new one specifically for that (describing the changes) @philouail .

@philouail
Copy link
Collaborator Author

I forgot that this was still open, super sorry about that. Will fix it.

@philouail philouail closed this Oct 2, 2024
@philouail
Copy link
Collaborator Author

Closing this PR as the MzTabParam method has been moved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants