-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of MzTabParam for export in .mztab format #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, thanks for that PR!
Yours, Steffen |
So - the update of this PR was to remove all the mzTab related things now and just have a fix for the LamaParama? I would then suggest to maybe close this PR and open a new one specifically for that (describing the changes) @philouail . |
I forgot that this was still open, super sorry about that. Will fix it. |
Closing this PR as the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the PR for the implementation of mztab-m export using the
storeResults
generic function combined with a param object of classMzTabParam
.For now, the export format only has the mandatory field available (as well as possibility to add
opt_
columns for the SMF table.In the future more metadata rows could be implemented if it makes sense from the format of XcmsExperiment object.
Any feedback and correction is welcomed.