-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: creation of new generic function so save XcmsExperiment object #698
Conversation
Oh and also I tried to do the necessary changes in |
For the NAMESPACE, just add
that should be enough. Description and NEWS are OK - yes, there is a different format here, but what you added is fine. |
Hi @sneumann so this PR is related to #693, it establish a new generics function Tell me if there is anything unclear or I need to change something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Phili! I'm fine with this PR.
Please @sneumann also have a look whether you're OK with the general approach we take here.
Only thing, @philouail , please address the one point regarding the dll file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, looks good to me, thanks for the nice work !
Yours, Steffen
Cool, so ready to merge from my side. |
Hi so this is just a draft, but I thought it might be easier to discuss here. I might need a bit of back and forth as it's the first time I do that :) Hope it's fine for you to do it like that. I'll also leave it as draft to avoid confusion.
See my comments for the parts that I'm confused about !