Enable data and value to be updated in same callback #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnMarieW
requested review from
snehilvj and
alexcjohnson
and removed request for
snehilvj
alexcjohnson
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
💃 This looks good to me. If you wanted to be extra cautious, you could add a counter to the callbacks in the tests (like in the dash test cbsc001 for example, to verify that the two useDidUpdate calls don't result in two callback calls. But I'm confident that's not going to be an issue so feel free to ignore this suggestion 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #411
In 0.14.7, there was a regression where it was not possible to update both the value and the data in the same callback in
SelectandMultiSelectThis issue occurred because there are two calls to
setSelected, and in PR #383, the order in which these calls were made changed. I considered combining them into a singleuseDidUpdatefunction, but that approach would have led to excessive calls to this function for clearing invalid selected values when data is updated in a callback.Todo