Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add autoComplete prop to PasswordInput #482

Closed
Erraen opened this issue Jan 20, 2025 · 2 comments
Closed

[Feature Request] Add autoComplete prop to PasswordInput #482

Erraen opened this issue Jan 20, 2025 · 2 comments

Comments

@Erraen
Copy link

Erraen commented Jan 20, 2025

Hi and thanks for this awesome library!

In some cases, is it would be nice to be able to customize autoComplete property for PasswordInput (for example, in a password change form, to be able to set autoCompete="new-password" to prevent browsers from autofilling).

@AnnMarieW
Copy link
Collaborator

Hi @Erraen and glad you are enjoying DMC 🙂

You make a good point. The default is set to autoComplete='off' for the PasswordInput but it should be possible to change it like you suggested.

If you would like to do a PR, this is a great first issue. If not, I already have an open PR in the works to add missing props and I could add this one. Just let me know - so it can make into the next release.

@AnnMarieW AnnMarieW mentioned this issue Jan 19, 2025
12 tasks
@AnnMarieW
Copy link
Collaborator

I added this request to #428, so I'm closing this as a duplicate. Feel free to add extra comments over there 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants