-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing props #428
Comments
Hi, I'd like to work on adding the |
You got it! Thanks so much @ChinoUkaegbu 🚀 |
According to @mantinedev/mantine, when using And also sign me up for this task! ps. Could you pls show me a quick sample of how to prepare a test for a PR? |
Regarding "prop to |
Also, sign me up for this task, too. |
Hi @namakshenas Thanks for offering to do the container query updates! See my updated comments above on tests. It's not necessary to write tests for the Grid and SimpleGrid components, because they only have pass-through props and don't trigger Dash callbacks. But if you could make a sample app with the container query examples from the Mantine docs, that would be ideal. |
Hi @AnnMarieW Sorry for being late on this. I started working on this. Could you pls help me fix this issue? I'm getting a strange error while testing a sample code for
Here is the content of my requirements.txt:
|
@namakshenas |
Getting the same error. python version: 3.11.9 entrirely purged the local dmc and then cloned it again. Add the commit; again same error! |
@namakshenas are you unable to create the PR? It would be easier to help that way |
I created a PR and pushed it into the following branch: https://github.com/namakshenas/dash-mantine-components/tree/add-type-simplegrid |
@namakshenas I don't see a PR here, but I looked at your branch. No need to include the example app in the PR as it will have to be deleted later. You can just include it as comment when you open the issue. I don't see anything that would cause an error. |
The following are all "Good First Issues".
It's OK to do this in several PRs. If it's your first contribution, feel free to start with just one.
If you would like to do one or more, please mention it in a comment so we don't duplicate efforts 🙂
Please include:
Optional:
Add
type
andbreakpoints
prop toGrid
to support Container Queries. Added in 7.13.0 Status: in progress by @namakshenasAdd
name
prop toAvatar
to support displaying [avatar initials] (https://mantine.dev/changelog/7-11-0/#avatar-initials ) with auto generated color based on the given name) with auto generated color based on the given name . Added in 7.11.0 Status in progress by AnnMarieWAdd
gradient
prop toLineChart
to render line with a gradiant fill Added in 7.11 Status: In progress by AnnMarieWAdd
acceptValueOnBlur
toTagsInput
. Added in 7.11. Status: in progress by @AnnMarieWAdd
hideWithOnePage
prop toPagination
which hides pagination when there is only one page. Added in 7.11. Status in progress by AnnMarieAdd
lineSize
prop toBurger
to supports change lines height Added in 7.11. Status: In progress by @ChinoUkaegbuAdd
type
prop toSimpleGrid
to support Container Queries. Added in 7.13.0 in progress by @namakshenasAdd
withKeyboardEvents
prop toNumberInput
. When set to False, it will disable up/down arrow keys handling Added in 7.8 update - I tried adding this prop and it seemed to have no effect. It may not be necessary to add since it's possible to disable the input and/or hide the controls. I'll leave it open if anyone else wants to try it, but I think it's ok to exclude this one.Addd
allowedInitialsColors
toAvatar
Add missing props #478Add
inline
toCenter
component. Add missing props #478Add
defaultExpanded
toCodeHighLightTabs
component Add missing props #478Add Add autoComplete prop to PasswordInput as requested in [Feature Request] Add autoComplete prop to PasswordInput #482
The text was updated successfully, but these errors were encountered: