Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo examples #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix demo examples #23

wants to merge 1 commit into from

Conversation

erentar
Copy link

@erentar erentar commented May 16, 2024

demo.ipynb had some wrong elements, i correct these discrepancies in this pr.

@fabricebrito
Copy link
Member

Thanks for this and sorry for the painful debugging experience. This project was created for a version of SNAP back in the days.
I've reached out to ESA a few times to understand the future of this project but got no feedback. At some point I got the feeling it would be integrated in the SNAP project but it never happened.
Its maintenance is thus low priority as we have other open source priorities.

@erentar
Copy link
Author

erentar commented May 16, 2024

I did not mean to berate the project by saying "many hours of debugging", all i wish to is to prevent others the same troubleshooting by giving a correct example

Thank you for your efforts in building this project, it is helping me a lot at the moment

@erentar erentar changed the title update the only source of documentation after many hours of painful debugging Fix demo examples May 17, 2024
@fabricebrito
Copy link
Member

@erentar looking at the PR I guess the changes are related to SNAP 9 (or 10, don't know) while the original demo is based on SNAP 8

Operators interfaces may change between SNAP releases and this is why snapista is "dynamic"

I guess the way forward is to split the demo notebooks into SNAP version based.

I'll try to find time to work this out.

Thanks for your feedback and efforts. Sorry for your initial frustration :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants