Merge pull request #16 from sn-satyendra/jsdom-peerdep

jsdom should be a peer dependency
sn-satyendra · Mar 20, 2021 · c951757 · c951757
2 parents 66a8a0b + 6eaaea2
commit c951757
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "webpack-font-preload-plugin",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "A webpack plugin to allow preloading or prefetching of fonts.",
   "main": "src/cjs.js",
   "scripts": {
@@ -23,7 +23,8 @@
     "prefetch"
   ],
   "peerDependencies": {
-    "webpack": "^4.0.0 || ^5.0.0"
+    "webpack": "^4.0.0 || ^5.0.0",
+    "jsdom": "^16.0.0"
   },
   "author": "Satyendra Singh Naruka",
   "license": "MIT",

diff --git a/src/index.js b/src/index.js
@@ -104,9 +104,9 @@ class WebpackFontPreloadPlugin {
         head.innerHTML = `${links}${head.innerHTML.trim()}`;
       } else {
         const parent = insertBeforeTag.parentNode;
-        const newNodes = this.createNodeFromHtml(document, links);
+        const newNodes = Array.from(this.createNodeFromHtml(document, links));
         if (newNodes && newNodes.length > 0) {
-          Array.from(newNodes).forEach((n) => {
+          newNodes.forEach((n) => {
             parent.insertBefore(n, insertBeforeTag);
           });
         }