Manage a wrapper for running ruby on Windows

Inspired by choria-io#145 (comment) When the agent_shim filenamed ends with '.bat', install a wrapper batch file that run the actual '.rb' file.
smortex · Jan 17, 2020 · da4ccb3 · da4ccb3
1 parent 70361b0
commit da4ccb3
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/data/os/windows.yaml b/data/os/windows.yaml
@@ -4,7 +4,7 @@ choria::server_config:
   classesfile: "C:/ProgramData/PuppetLabs/puppet/cache/state/classes.txt"
   plugin.rpcaudit.logfile: "C:/ProgramData/choria/var/log/choria-audit.log"
   plugin.yaml: "C:/ProgramData/choria/etc/generated-facts.yaml"
-  plugin.choria.agent_provider.mcorpc.agent_shim: "C:/Program Files/choria/bin/choria_mcollective_agent_compat.rb"
+  plugin.choria.agent_provider.mcorpc.agent_shim: "C:/Program Files/choria/bin/choria_mcollective_agent_compat.bat"
   plugin.choria.agent_provider.mcorpc.config: "C:/ProgramData/choria/etc/choria-shim.cfg"
   plugin.choria.agent_provider.mcorpc.libdir: "C:/ProgramData/choria/lib/plugins"
 choria::rubypath: "C:/Program Files/Puppet Labs/Puppet/puppet/bin/ruby.exe"

diff --git a/manifests/config.pp b/manifests/config.pp
@@ -41,12 +41,28 @@
   }
 
   if "plugin.choria.agent_provider.mcorpc.agent_shim" in $choria::server_config  and "plugin.choria.agent_provider.mcorpc.config" in $choria::server_config {
-    file{$choria::server_config["plugin.choria.agent_provider.mcorpc.agent_shim"]:
+    if $choria::server_config["plugin.choria.agent_provider.mcorpc.agent_shim"] =~ /\.bat$/ {
+      $agent_shim = $choria::server_config["plugin.choria.agent_provider.mcorpc.agent_shim"].regsubst(/\.bat$/, '.rb')
+      $agent_shim_wrapper = $choria::server_config["plugin.choria.agent_provider.mcorpc.agent_shim"]
+    } else {
+      $agent_shim = $choria::server_config["plugin.choria.agent_provider.mcorpc.agent_shim"]
+      $agent_shim_wrapper = undef
+    }
+
+    file{$agent_shim:
       owner   => $choria::config_user,
       group   => $choria::config_group,
       mode    => "0755",
       content => epp("choria/choria_mcollective_agent_compat.rb.epp")
     }
+    if $agent_shim_wrapper {
+      file{$agent_shim_wrapper:
+        owner   => $choria::config_user,
+        group   => $choria::config_group,
+        mode    => "0755",
+        content => epp("choria/choria_mcollective_agent_compat.bat.epp")
+      }
+    }
   }
 
   if $choria::manage_server_config {

diff --git a/templates/choria_mcollective_agent_compat.bat.epp b/templates/choria_mcollective_agent_compat.bat.epp
@@ -0,0 +1,3 @@
+@echo off
+setlocal
+"<%= $choria::rubypath %>" -S -- "<%= $choria::server_config["plugin.choria.agent_provider.mcorpc.agent_shim"].regsubst(/\.bat$/, '.rb') %>" --config "<%= $choria::server_config_file %>" %*