Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump react navigation from 4.x to 6.x #152

Closed
wants to merge 53 commits into from
Closed

bump react navigation from 4.x to 6.x #152

wants to merge 53 commits into from

Conversation

MrScriptX
Copy link
Collaborator

@MrScriptX MrScriptX commented May 31, 2024 •
edited
Loading

  • Upgrade Dependencies: Update React Navigation and its dependencies to v6.
  • Refactor Codebase: Adjust navigation code to comply with v6's API changes and best practices.
  • Refactor StudyScreen & EditStudyScreen
  • Test All Navigation Flows: Ensure smooth navigation functionality across the app.

Closes #132

MrScriptX and others added 30 commits May 27, 2024 22:15
@MrScriptX
replace deprecated stack navigator with replacement
c76b34d
@MrScriptX
all routes added to MainStackNavigator & headermode added
c47130a
refactor AppNavigator to 6.x react nav api
a732726
replace NavigationStackProp with StackNavigationProp & use withNaviga…
dcf1f1b 
…tion from compat pkg
replacing NavigationStackProp with StackNavigationProp
61ed671
refactor WebViewQuillEditor to use @react-navigation/native for navig…
129ddc9 
…ation
refactor Verse.tsx to use @react-navigation/native for navigation
6f67f42
refactor TagList to use @react-navigation/native for navigation
916127e
refactor Comment component to use @react-navigation/native for naviga…
969e45e 
…tion
refactor navigation imports to use @react-navigation/native
e9224cb
@MrScriptX
react-native-gesture-handler should use one version & remove compat p…
a74c19d 
…ackage
@MrScriptX
refactor navigation imports to use @react-navigation/native
aaf32c6
@MrScriptX
refactor navigation imports to use @react-navigation/native
56aa7d8
@MrScriptX
refactor navigation imports to use @react-navigation/native
1b913ea
@MrScriptX
createAnimatedBottomTabNavigator unused
7509887
@MrScriptX
missing type package for color
e532387
@MrScriptX
typing screens
f4cd99e
@MrScriptX
refactor createAnimatedBottomTabNavigator to use @react-navigation/na…
4abf2fa 
…tive
refactor BibleVerseDetailScreen to use function API instead of the ol…
53a2976 
…d class component API
fix typing for callbacks
585c3b8
pass data through params and not props
faed341
Fix links & more navigation/route hooks
8ee5fbd
@MrScriptX
fix type check
de877a3
@MrScriptX
fix link in MoreScreen
74cd4fe
@MrScriptX
fix lexique item viewing
ba85b0f
@MrScriptX
fix dictionnary item view
79e0648
@MrScriptX
fix NaveItem navigation
1209136
@MrScriptX
more links to be fixed
4374eb6
@MrScriptX
refactor Link component to use generics for better type checking
61e7a63
@MrScriptX
adding param object to BibleVerseNotes
125524f
MrScriptX and others added 23 commits June 5, 2024 21:45
@MrScriptX
VerseNotesScreen using function component
ce6a820
@MrScriptX
refactor BibleNoteItem component to use TypeScript and add type checking
d6323f6
@MrScriptX
refactoring of BibleVerseDetailCard to function component
1838957
@MrScriptX
update yarn lock (should it be included ?)
14da0e9
@MrScriptX
prettier
8dc177c
@MrScriptX
props shoudln't be passed to main navigator (maybe ?)
8aa8579
@MrScriptX
Accepts children
ab3e8d2
@MrScriptX
refactor BibleVerseDetailScreen to use useTheme hook
51de100
@MrScriptX
fix Bible Header links
f1262cc
@MrScriptX
fix version selection
b3398c5
@MrScriptX
fix navigate for webview
e5b6bed
@MrScriptX
fix login button
150f3f3
@MrScriptX
js to tsx file
a6b3329
refactor UserWidget to pass navigation prop to Chip components
4bf7e74
type Chip
e132b1c
fix notes from homescreen and remove redux connect
aa6cbcb
fix Notes List & typing (somewhat)
f1a521f
trying to fix EditStudy
57ec92a
WebViewQuill fix (on going)
9b1771c
@MrScriptX
consistent loading of Study in WebView (but still error pop up)
25888a1
refactor TagItem component to use TypeScript and pass navigation prop
540f5d2
@MrScriptX
merge withStudy in EditStudyScreen
28089b8
@MrScriptX
Merge branch 'react-navigation' of github.com:MrScriptX/bible-strong …
f8b68ed 
…into react-navigation
@smontlouis smontlouis mentioned this pull request Nov 20, 2024
Merged
4 tasks
@smontlouis smontlouis closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade React Navigation from v4 to v6
2 participants
@MrScriptX @smontlouis