Major improvements #29
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check it out! |
|
This PR breaks the live preview for Subvert. When I run LSubvert on this branch, I do not get any live preview. I do get live-preview on the current main branch. I do not see any crashes though, so that's OK. |
smjonas
force-pushed
the
remote
branch
2 times, most recently
from
37606be to
db3294e
Compare
Thanks for your feedback. I fixed an issue in the implementation and I hope the |
smjonas
force-pushed
the
remote
branch
7 times, most recently
from
cc37d38 to
85f7d8b
Compare
smjonas
force-pushed
the
remote
branch
2 times, most recently
from
29a0244 to
c0592db
Compare
smjonas
force-pushed
the
remote
branch
4 times, most recently
from
e34f8f5 to
d55ad8b
Compare
|
Hi @smjonas ! This branch seems to work very well, although my lualine still flickers at times with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to significantly improve the command preview functionality by addressing highlighting and responsiveness issues present in the current implementation. Previously,
vim.cmdwas called from the preview callback to execute the command in the current Nvim instance due to the command being run from command mode.To resolve these issues, the new approach implemented in this PR is to spawn a separate Neovim instance to execute the commands, making the command execution completely independent from the current instance. Of course, this may have some performance implications since a new Nvim instance has to be created in the
setupfunction. Thus, I am looking for feedback on your experience and any issues you may encounter. But generally, the new implementation seems to work a lot better.You can try out this feature by using the
remotebranch. I am pinging any of the users involved in the related issues, and would ask you to leave feedback if you are interested: @mateiadrielrafael, @gregorias, @nfrid, @emmanueltouzery, @sibouras, @AckslDCloses #6, closes #16, closes #24. closes #28.
TODO: