Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when normal command does not match #6

Open
AckslD opened this issue Aug 15, 2022 · 3 comments · May be fixed by #29
Open

Issue when normal command does not match #6

AckslD opened this issue Aug 15, 2022 · 3 comments · May be fixed by #29
Labels
bug Something isn't working Nvim core Requires a fix in Neovim core

Comments

@AckslD
Copy link

AckslD commented Aug 15, 2022

Really cool plugin! I started taking it for a spin and one issue I noticed is that the preview is not correct if some line does not contain a match for eg f.

For example lets say you have the buffer:

foo
bar

and you type :%Norm foix. Then before pressing <CR> the preview looks like:

fxoo
xbar

whereas after pressing <CR> you actually get:

fxoo
bar
@smjonas smjonas added the bug Something isn't working label Aug 15, 2022
@smjonas
Copy link
Owner

smjonas commented Aug 15, 2022

Really cool plugin!

Thanks <3

I just noticed this should now also be fixed on main (it is for me) :) Let me know if that's not the case!

@smjonas smjonas closed this as completed Aug 15, 2022
@AckslD
Copy link
Author

AckslD commented Aug 15, 2022

It now seems to only preview the first line, eg if the buffer instead is

foo
bar
foo

then the preview from the same command is

fxoo
bar
foo

instead of

fxoo
bar
fxoo

@smjonas
Copy link
Owner

smjonas commented Aug 16, 2022

This looks like an upstream issue. I have reported it here: neovim/neovim#19807

@smjonas smjonas added the Nvim core Requires a fix in Neovim core label Aug 16, 2022
@smjonas smjonas linked a pull request Apr 16, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Nvim core Requires a fix in Neovim core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants