feat(experimentalIdentityAndAuth): reorganize package structure into NPM packages #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
ts-ia-reorganize-npm-package
branch
from
22739f2 to
1c6e93c
Compare
AndrewFossAWS
approved these changes
Oct 10, 2023
syall
force-pushed
the
ts-ia-reorganize-npm-package
branch
from
1c6e93c to
9bb939a
Compare
syall
commented
Oct 10, 2023
Comment on lines
-1
to
+8
| export * from "./HttpAuthScheme"; | ||
| export * from "./HttpAuthSchemeProvider"; | ||
| export * from "./HttpSigner"; | ||
| export * from "./IdentityProviderConfig"; | ||
| export * from "./SigV4Signer"; | ||
| export * from "./apiKeyIdentity"; | ||
| export * from "./endpointRuleSet"; | ||
| export * from "./httpApiKeyAuth"; | ||
| export * from "./httpBearerAuth"; | ||
| export * from "./memoizeIdentityProvider"; | ||
| export * from "./middleware-http-auth-scheme"; | ||
| export * from "./middleware-http-signing"; | ||
| export * from "./noAuth"; | ||
| export * from "./tokenIdentity"; | ||
| export * from "./signature-v4"; | ||
| export * from "./types"; | ||
| export * from "./util-endpoint-rule-set-auth"; | ||
| export * from "./util-http-api-key-auth"; | ||
| export * from "./util-http-bearer-auth"; | ||
| export * from "./util-identity-and-auth"; |
There was a problem hiding this comment.
These are the NPM packages where the code in this experimental package would go, and needs the most feedback.
Particularly, I am thinking that all the util-* packages should just be collapsed under util-identity-and-auth, and separated later if needed.
Even the Sigv4Signer could go under util-identity-and-auth to avoid confusion with the existing code in signature-v4.
There was a problem hiding this comment.
I think it should all be in as few packages as possible since I/we want to reduce the number of overall packages in the future.
syall
force-pushed
the
ts-ia-reorganize-npm-package
branch
4 times, most recently
from
003f6f1 to
768abc9
Compare
syall
force-pushed
the
ts-ia-reorganize-npm-package
branch
from
768abc9 to
03fdc57
Compare
|
Closed in favor of: #1068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
Dependent on: #1002, #1004
Reorganize package structure into NPM packages.
If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.