Fix constraint-related errors in Rpcv2CBOR server implementation #3794

drganjoo · 2024-08-19T14:50:43Z

This PR addresses issues with code generation related to constraints for the Rpcv2CBOR protocol.

Additionally, it introduces protocol-based model transformation on the server side. This transformation ensures that elements in the model not supported by Rpcv2CBOR, such as httpBinding related traits, are removed before code generation.

github-actions · 2024-08-19T15:09:19Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

ysaito1001 · 2024-08-19T17:46:47Z

Can we add a changelog entry with applies_to: ["server", "client"] that announces the basic support for the protocol as part of this PR (FWIW, I've been able to call CloudWatch and Secrets Manager with RPC v2 CBOR)?

…o fahadzub/cbor-constraint

github-actions · 2024-09-04T10:48:24Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2024-09-04T11:39:46Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2024-09-04T18:18:05Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

…e for event stream

github-actions · 2024-09-08T19:42:29Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
Client Test (ignoring whitespace)
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2024-09-09T09:23:32Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
Client Test (ignoring whitespace)
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2024-09-09T10:25:52Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
Client Test (ignoring whitespace)
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2024-09-09T12:35:14Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
Server Test (ignoring whitespace)
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2024-09-09T14:39:30Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
Client Test (ignoring whitespace)
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

david-perez

lgtm; just a few nits

.changelog/2155171.md

...-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/RpcV2Cbor.kt

...e/src/main/kotlin/software/amazon/smithy/rust/codegen/core/testutil/EventStreamTestModels.kt

...n/smithy/rust/codegen/server/smithy/transformers/ServerProtocolBasedTransformationFactory.kt

david-perez · 2024-09-17T10:46:47Z

...-server/src/test/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ConstraintsTest.kt

+ */
+fun loadSmithyConstraintsModel(): Pair<Model, ShapeId> {
+    val filePath = "../codegen-core/common-test-models/constraints.smithy"
+    val serviceShapeId = ShapeId.from("com.amazonaws.constraints#ConstraintsService")


nit: you could expect it from the parsed model below instead of hardcoding it.

Have changed it to return the first service shape in the constraints file.

Co-authored-by: david-perez <[email protected]>

…en/core/smithy/protocols/RpcV2Cbor.kt Co-authored-by: david-perez <[email protected]>

…en/core/testutil/EventStreamTestModels.kt Co-authored-by: david-perez <[email protected]>

…tory class will be removed later on

github-actions · 2024-09-17T12:56:22Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
Client Test (ignoring whitespace)
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2024-09-18T10:55:35Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
Client Test (ignoring whitespace)
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2024-09-30T09:54:03Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
Client Test (ignoring whitespace)
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2024-09-30T15:52:56Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
Client Test (ignoring whitespace)
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2024-10-01T11:53:03Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
Client Test (ignoring whitespace)
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

drganjoo added the server Rust server SDK label Aug 19, 2024

drganjoo requested review from a team as code owners August 19, 2024 14:50

drganjoo marked this pull request as draft August 22, 2024 09:57

Fahad Zubair added 5 commits August 30, 2024 12:52

Use constraints.smithy with CBor

d026ad1

Use CBOR encoded string for marhsalling tests

fd8c25c

Remove streaming trait from blob

6afc8bf

Use constraints.smithy with CBor

3fede97

Use CBOR encoded string for marhsalling tests

5bb92b1

drganjoo force-pushed the fahadzub/cbor-constraint branch from 39d57f3 to 5bb92b1 Compare September 4, 2024 10:11

Merge remote-tracking branch 'cbor-fixe/fahadzub/cbor-constraint' int…

f2c11b8

…o fahadzub/cbor-constraint

Fix formatting and comments

763d598

drganjoo force-pushed the fahadzub/cbor-constraint branch from 829cc8d to 763d598 Compare September 4, 2024 11:13

Merge branch 'main' into fahadzub/cbor-constraint

b961f18

Implement parseEventStreamErrorMetadata, and change client test cas…

91d80a4

…e for event stream

Add copyright

d51cc78

Add changelog and fix lint issues

050d9c5

drganjoo force-pushed the fahadzub/cbor-constraint branch from ea69024 to 050d9c5 Compare September 9, 2024 12:16

Merge branch 'main' into fahadzub/cbor-constraint

4e351cb

drganjoo marked this pull request as ready for review September 9, 2024 14:18

drganjoo added the client label Sep 16, 2024

david-perez approved these changes Sep 17, 2024

View reviewed changes

drganjoo and others added 6 commits September 17, 2024 13:20

Update .changelog/2155171.md

3e74cc8

Co-authored-by: david-perez <[email protected]>

Update .changelog/2155171.md

8bf71f1

Co-authored-by: david-perez <[email protected]>

Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codeg…

13c0c78

…en/core/smithy/protocols/RpcV2Cbor.kt Co-authored-by: david-perez <[email protected]>

Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codeg…

c36dfb0

…en/core/testutil/EventStreamTestModels.kt Co-authored-by: david-perez <[email protected]>

Add comments to clarify that the ServerProtocolBasedTransformationFac…

5bbfdc2

…tory class will be removed later on

Merge branch 'main' into fahadzub/cbor-constraint

432e0f9

Merge branch 'main' into fahadzub/cbor-constraint

9977516

Merge branch 'main' into fahadzub/cbor-constraint

fcf670d

drganjoo enabled auto-merge September 30, 2024 09:36

Merge branch 'main' into fahadzub/cbor-constraint

35a9099

Merge branch 'main' into fahadzub/cbor-constraint

27ca7f1

aws-sdk-rust-ci removed the client label Oct 1, 2024

aws-sdk-rust-ci disabled auto-merge October 1, 2024 13:04

aws-sdk-rust-ci merged commit 191c577 into main Oct 1, 2024
44 checks passed

aws-sdk-rust-ci deleted the fahadzub/cbor-constraint branch October 1, 2024 13:05

drganjoo mentioned this pull request Oct 15, 2024

Rpcv2Cbor implementation does not work with constraints #3788

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix constraint-related errors in Rpcv2CBOR server implementation #3794

Fix constraint-related errors in Rpcv2CBOR server implementation #3794

drganjoo commented Aug 19, 2024

github-actions bot commented Aug 19, 2024

ysaito1001 commented Aug 19, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 8, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

david-perez left a comment

david-perez Sep 17, 2024

drganjoo Sep 17, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 1, 2024

Fix constraint-related errors in Rpcv2CBOR server implementation #3794

Fix constraint-related errors in Rpcv2CBOR server implementation #3794

Conversation

drganjoo commented Aug 19, 2024

github-actions bot commented Aug 19, 2024

ysaito1001 commented Aug 19, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 8, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

david-perez left a comment

Choose a reason for hiding this comment

david-perez Sep 17, 2024

Choose a reason for hiding this comment

drganjoo Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 1, 2024