Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor ci workflows #974

Merged
merged 4 commits into from
Oct 11, 2023
Merged

chore: refactor ci workflows #974

merged 4 commits into from
Oct 11, 2023

Conversation

aajtodd
Copy link
Contributor

@aajtodd aajtodd commented Oct 10, 2023

Issue #

n/a

Description of changes

Refactor CI to no longer need CRT builder (still used by codebuild jobs for now though). Restructures main PR workflow to test against a matrix of JVM versions and match upstream aws-sdk-kotlin awslabs/aws-sdk-kotlin#1069

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aajtodd aajtodd requested a review from a team as a code owner October 10, 2023 17:31
@aajtodd aajtodd added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Oct 10, 2023
Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wonder if it would be possible to redefine some of these CI tests as actions in aws-kotlin-repo-tools to reduce duplication and synchronize the JDKs and OSes being used.

@aajtodd
Copy link
Contributor Author

aajtodd commented Oct 11, 2023

Looks good. I wonder if it would be possible to redefine some of these CI tests as actions in aws-kotlin-repo-tools to reduce duplication and synchronize the JDKs and OSes being used.

I think over time possibly yes. I think I'd like to see about eventually getting rid of CRT builder in codebuild jobs and see what we can share across custom GH actions and codebuild in terms of scripts and go from there. I see this as a stepping point, I imagine when we take the time to commonize a docker image, etc there will be more we can do as well.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aajtodd aajtodd merged commit 15e6cc5 into main Oct 11, 2023
13 of 14 checks passed
@aajtodd aajtodd deleted the release-checks branch October 11, 2023 14:38
aajtodd added a commit that referenced this pull request Mar 11, 2024
Refactor observability (tracing) API and introduce an OTeL backed provider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants