refactor!: rename metrics and remove redundant metrics #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
reviewed
Oct 9, 2023
| { | ||
| "id": "c063605b-4702-4d8a-a841-2e0b7aa78e78", | ||
| "type": "misc", | ||
| "description": "**BREAKING**: Remove `smithy.client.request.size`, `smithy.client.response.size`, `smithy.client.retires` metrics. Rename all `smithy.client.*` metrics to `smithy.client.call.*`." |
There was a problem hiding this comment.
Nit: There's a type here in retries
0marperez
approved these changes
Oct 9, 2023
lauzadis
approved these changes
Oct 11, 2023
| */ | ||
| public interface SpanContext { | ||
| public companion object { | ||
| public val Invalid: SpanContext = InvalidSpanContext |
There was a problem hiding this comment.
When would an "invalid" SpanContext ever be used/desired? If it's meant to be used as a default when no context is set, I'd avoid the word "invalid"
There was a problem hiding this comment.
https://opentelemetry.io/docs/specs/otel/trace/api/#isvalid
Spans may not be valid when there is no configured telemetry provider.
Comment on lines
+37
to
+38
| override val traceId: String = "00000000000000000000000000000000" | ||
| override val spanId: String = "0000000000000000" |
There was a problem hiding this comment.
How are these values determined?
ianbotsf
approved these changes
Oct 11, 2023
aajtodd
force-pushed
the
refactor-telemetry
branch
from
126b232 to
ca7ce63
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
n/a
Description of changes
smithy.client.request.size,smithy.client.response.size, andsmithy.client.retriesmetricssmithy.client.*metrics tosmithy.client.call.*SpanContexttoTraceSpansetContextfrom fluent log builder in-favor of explicitly setting span context K/V pairsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.