-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cleanup public symbols and rename transform package #971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm wonder how that happened 🤔 , good catch.
{ | ||
"id": "2652a0e3-6588-4542-a35d-eafd5adf8c77", | ||
"type": "misc", | ||
"description": "Refactor codegen to place serialization and serialization into the `serde` package rather than the `transform` package. Relocate `TlsVersion` to the `net` package. Make `ByteArrayContent` and friends `internal` and force consumers to go through companion object convenience functions." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd vote for splitting these unrelated changes out into separate changelog entries
if (TopDownIndex(ctx.model).getContainedOperations(ctx.service).isNotEmpty()) { | ||
writer.addImport("${ctx.settings.pkg.name}.transform", "*") | ||
writer.addImport(ctx.settings.pkg.serde, "*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this still reference the package name somewhere? I was thinking it would be ${ctx.settings.pkg.name}.serde
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctx.settings.pkg.serde
effectively resolves to ${ctx.settings.pkg.name}.serde
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Issue #
n/a
Description of changes
Miscellaneous cleanup
serde
rather thantransform
package. This better matches our own terminology and was leftover from "do what Java does".TlsVersion
into thenet
subpackage rather thanconfig
StringContent
andByteArrayContent
internal
and force consumers to go through the companion objects for the given types. e.g.ByteStream.fromBytes(...)
rather thanByteArrayContent(...)
. Same forHttpBody.fromBytes(...)
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.