misc: Upgrade to Kotlin 2.1.0 #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
reviewed
Dec 16, 2024
| kotlin-compile-testing = {module = "com.github.tschuchortdev:kotlin-compile-testing", version.ref = "kotlin-compile-testing-version" } | ||
| kotlin-compile-testing = {module = "dev.zacsweers.kctfork:core", version.ref = "kotlin-compile-testing-version" } |
There was a problem hiding this comment.
Question: Why are we changing this dependency?
There was a problem hiding this comment.
We're frequently blocked on com.github.tschuchortdev:kotlin-compile-testing because its Kotlin version is not upgraded often enough, leading to mismatched Kotlin compiler errors.
tschuchortdev/kotlin-compile-testing#411
dev.zacsweers.kctfork:core is a fork of the project that's updated more frequently:
NOTE This project is a fork of the original tschuchortdev/kotlin-compile-testing, which itself started as a fork of Moshi's compile test infra. The goal of this fork is to better track the latest Kotlin releases.
We can either take this fork or disable the tests.
There was a problem hiding this comment.
Oh okay, I think taking the fork is fine
0marperez
approved these changes
Dec 16, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Affected ArtifactsChanged in size
|
ianbotsf
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.