misc: add Accept header to all RpcV2Cbor requests
#1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ianbotsf
requested changes
Oct 30, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
0marperez
approved these changes
Oct 30, 2024
| operations: [GetFoo, GetFooStreaming] | ||
| } | ||
|
|
||
| @http(method: "POST", uri: "/foo") |
There was a problem hiding this comment.
Small nit, feel free to ignore it: This looks like it should be "GET" instead of "POST"
There was a problem hiding this comment.
Same thing for the GetFooStreaming operation
There was a problem hiding this comment.
If we make it a GET request Smithy fails with some "DANGER" level validations about sending bodies with GET. Setting up POST operations is simpler and the distinction is not important to the test
| ctx.generationCtx.delegator.flushWriters() | ||
|
|
||
| val actual = ctx.manifest.expectFileString("/src/main/kotlin/com/test/DefaultTestClient.kt") | ||
| println(actual) |
There was a problem hiding this comment.
Nit: Stray print statements here and in the next test
Affected ArtifactsChanged in size
|
ianbotsf
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.