feat: expand use of chunked content encoding
#1018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
suggested changes
Dec 27, 2023
There was a problem hiding this comment.
This change seems ok but I don't think it addresses the underlying issue. If a user submits a request without a flexible checksum this would still fail right? I think we need to solve that because it looks like the request in the issue without a checksum should succeed as well unless I'm missing something.
| @@ -163,6 +165,12 @@ public class AwsHttpSigner(private val config: Config) : HttpSigner { | |||
| HashSpecification.StreamingAws4HmacSha256Payload | |||
| } | |||
| } | |||
| request.headers["x-amz-checksum-sha256"] != null -> { | |||
There was a problem hiding this comment.
suggestion: Should probably be a constant value somewhere.
|
lauzadis
changed the title
aws-chunked content encoding
lauzadis
changed the title
aws-chunked content encodingchunked content encoding
aajtodd
approved these changes
Dec 28, 2023
ianbotsf
approved these changes
Jan 2, 2024
Comment on lines
+46
to
+47
| get() = (this is HttpBody.SourceContent || this is HttpBody.ChannelContent) && | ||
| (isOneShot || (contentLength?.compareTo(AWS_CHUNKED_THRESHOLD) ?: 0) > 0) |
There was a problem hiding this comment.
Style: ?.compareTo works but is pretty verbose and still requires null-coalescing the value. Shorter would just be:
(contentLength ?: 0 > AWS_CHUNKED_THRESHOLD)Same comment applies below.
aajtodd
added a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a streaming body with an undefined content length is provided, upload it with
chunkedto ensure the hash can be properly calculated. This reduces occurrences of exceptions claimingStream must be replayable to calculate a body hashIssue #
Addresses an issue in awslabs/aws-sdk-kotlin#1157
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.