feedback

.changes/b1a1bee4-e3e4-4520-ae8e-48d3b0e94ae9.json

@@ -1,5 +1,5 @@
 {
     "id": "b1a1bee4-e3e4-4520-ae8e-48d3b0e94ae9",
     "type": "bugfix",
-    "description": "Do not log intermediate signature calculations without explicit opt-in via `LogMode.LogSignging`."
+    "description": "Do not log intermediate signature calculations without explicit opt-in via `LogMode.LogSigning`."
 }

runtime/auth/aws-signing-common/common/src/aws/smithy/kotlin/runtime/auth/awssigning/AwsSigningConfig.kt

@@ -166,9 +166,9 @@ public class AwsSigningConfig(builder: Builder) {
 
     /**
      * Flag enabling whether detailed trace logging is enabled (if the signer implementation supports it). When true
-     * signers should emit intermediate logging details such as the canonical request and string to sign at the trace
-     * level. This is an opt-in configuration because these intermediate outputs may contain sensitive fields bound
-     * to headers, URI, or query parmaeters.
+     * signers should emit intermediate logging details such as the canonical request at the trace level.
+     * This is an opt-in configuration because these intermediate outputs may contain sensitive fields bound
+     * to headers, URI, or query parameters.
      */
     public val enableTraceLogging: Boolean = builder.enableTraceLogging
 

runtime/smithy-client/common/test/aws/smithy/kotlin/runtime/client/LogModeTest.kt

@@ -45,8 +45,8 @@ class LogModeTest {
     @Test
     fun testFromStringComposite() {
         assertEquals(
-            LogMode.fromString("LogRequest|LogRequestWithBody|LogResponse"),
-            (LogMode.LogRequest + LogMode.LogRequestWithBody + LogMode.LogResponse),
+            LogMode.fromString("LogRequest|LogRequestWithBody|LogResponse|LogSigning"),
+            (LogMode.LogRequest + LogMode.LogRequestWithBody + LogMode.LogResponse + LogMode.LogSigning),
         )
     }