add a few explanatory comments

smithy-lang · Oct 30, 2024 · 12b0ce9 · 12b0ce9
1 parent 3ce4ae7
commit 12b0ce9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/...lient-engines/test-suite/jvm/src/aws/smithy/kotlin/runtime/http/test/suite/Connections.kt b/...lient-engines/test-suite/jvm/src/aws/smithy/kotlin/runtime/http/test/suite/Connections.kt
@@ -27,7 +27,7 @@ internal fun Application.connectionTests() {
                 val jettyCall = routingCall.engineCall as JettyApplicationCall
 
                 launch {
-                    delay(4.seconds)
+                    delay(4.seconds) // Close the connection ~4 seconds after the call ends
                     jettyCall.response.responseChannel().close()
                 }
 

diff --git a/...-client-engines/test-suite/jvm/test/aws/smithy/kotlin/runtime/http/test/ConnectionTest.kt b/...-client-engines/test-suite/jvm/test/aws/smithy/kotlin/runtime/http/test/ConnectionTest.kt
@@ -84,6 +84,7 @@ class ConnectionTest : AbstractEngineTest() {
     @Test
     fun testMinTls1_3() = testMinTlsVersion(TlsVersion.TLS_1_3, ServerType.TLS_1_3)
 
+    // See https://github.com/awslabs/aws-sdk-kotlin/issues/1214
     @Test
     fun testShortLivedConnections() = testEngines(
         // Only run this test on OkHttp