Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily Revert "Add exception on implicit empty config (#123)" #126

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Temporarily Revert "Add exception on implicit empty config (#123)" #126

merged 1 commit into from
Mar 7, 2024

Conversation

hpmellema
Copy link
Contributor

Background

  • Temporarily reverts commit 59f1454 that added a check for empty configs
  • The empty configs check is a potentially breaking change and so needs to be reverted to push a patch release of 0.10.0

Testing

  • N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hpmellema hpmellema requested a review from a team as a code owner March 7, 2024 14:45
@hpmellema hpmellema requested a review from AndrewFossAWS March 7, 2024 14:45
@hpmellema hpmellema merged commit 590302c into smithy-lang:main Mar 7, 2024
4 checks passed
@hpmellema hpmellema deleted the temp-revert-empty-config-change branch March 7, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesziemer milesziemer milesziemer approved these changes

@AndrewFossAWS AndrewFossAWS Awaiting requested review from AndrewFossAWS AndrewFossAWS is a code owner automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hpmellema @milesziemer