Refactor to use convention plugins for common configuration #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpmellema
commented
Jan 11, 2024
| import org.gradle.testkit.runner.BuildResult; | ||
| import org.gradle.testkit.runner.BuildTask; | ||
| import org.gradle.testkit.runner.TaskOutcome; | ||
| import org.junit.jupiter.api.Assertions; |
There was a problem hiding this comment.
fixes checkstyle violations.
hpmellema
commented
Jan 11, 2024
| @@ -28,4 +28,9 @@ | |||
| <Match> | |||
| <Bug pattern="EI_EXPOSE_REP2"/> | |||
| </Match> | |||
|
|
|||
| <!-- Excessive Defensive checks on constructor exceptions. --> | |||
| <Match> | |||
There was a problem hiding this comment.
new bug pattern added in newer spotbugs version
|
Nice. Ship it |
kstich
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Refactors the plugin to use convention plugins for common configuration rather than configuring all project using the subprojects block.
For more on convention plugins for common logic see: https://docs.gradle.org/current/userguide/sharing_build_logic_between_subprojects.html
This has a few benefits:
apply false)This PR also upgrades the plugins used by the project.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.