Move smithyCli configuration and correct issue with conventions #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpmellema
commented
Dec 21, 2023
...-base-plugin/src/main/java/software/amazon/smithy/gradle/internal/CliDependencyResolver.java
Outdated
Show resolved
Hide resolved
kstich
reviewed
Jan 2, 2024
smithy-base-plugin/src/main/java/software/amazon/smithy/gradle/SmithyBasePlugin.java
Outdated
Show resolved
Hide resolved
...-base-plugin/src/main/java/software/amazon/smithy/gradle/internal/CliDependencyResolver.java
Outdated
Show resolved
Hide resolved
smithy-base-plugin/src/main/java/software/amazon/smithy/gradle/tasks/BaseSmithyTask.java
Outdated
Show resolved
Hide resolved
kstich
approved these changes
Jan 11, 2024
hpmellema
force-pushed
the
update-usage-of-configurations
branch
from
59d1f3c to
2ecbbf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Corrects an issue where the conventions set for the smithyBuildtask were causing custom defined tasks used without the java plugin applied to fail. The failure was due to the conventions not lazily executing the pulling of the configurations used for each of the classpaths.
As part of fixing the above it was nicer to move the smithyCli config to always be created whenever the base plugin is applied even if no source sets are created. This allows users to apply the base plugin to resolve the cli artifact without needing to pass in a custom classpath with the CLI on it to the build task.
Applies some simple cleanup and renames the "RuntimeClasspath" parameter to "ModelDiscoveryClasspath" parameter for clarity for users using the build task on its own.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.