Use gradle.properties for gradle plugin version #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenbaker
reviewed
Feb 14, 2024
Comment on lines
+18
to
19
| curl -sL https://api.github.com/repos/smithy-lang/smithy/releases/latest | \ | ||
| jq -r '.tag_name')" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Once we switch over the CLI release, we'll start including the VERSION file in the release assets. Instead of relying on the GH api, we can use the version-file too if we wanted. Occasionally, the api is finicky.
haydenbaker
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates the examples in the repository to use gradle properties to set the gradle plugin version. This will make it a bit easier to update the plugin version via github actions.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.