Create MultiNode Adaptor #7
Open
+567
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanTinianov
force-pushed
the
BCFR-1071-multinode-adaptor
branch
from
988f9b2 to
cfbc9d2
Compare
…tcontractkit/chainlink-framework into BCFR-1071-multinode-adaptor
| } | ||
|
|
||
| // Adapter is used to integrate multinode into chain-specific clients | ||
| type Adapter[RPC any, HEAD Head] struct { |
There was a problem hiding this comment.
It would be nice also to provide a standardized method for measuring latency (including prom metrics)
| // chStopInFlight can be closed to immediately cancel all in-flight requests on | ||
| // this RpcMultiNodeAdapter. Closing and replacing should be serialized through | ||
| // stateMu since it can happen on state transitions as well as RpcMultiNodeAdapter Close. | ||
| chStopInFlight chan struct{} |
There was a problem hiding this comment.
Should we rename this to a lifeCycleCh to signal that it's closed once RPC is declared unhealthy?
|
|
||
| // GetChStopInflight provides a convenience helper that mutex wraps a | ||
| // read to the chStopInFlight | ||
| func (m *Adapter[RPC, HEAD]) GetChStopInflight() chan struct{} { |
There was a problem hiding this comment.
Do we need all GetChStopInflight, MakeQueryCtx and AcquireQueryCtx methods?
| return m.chStopInFlight | ||
| } | ||
|
|
||
| func (m *Adapter[RPC, HEAD]) ResetLatestChainInfo() { |
There was a problem hiding this comment.
Do we need this public?
| } | ||
|
|
||
| func (m *Adapter[RPC, HEAD]) GetInterceptedChainInfo() (latest, highestUserObservations ChainInfo) { | ||
| m.chainInfoLock.Lock() |
| c := newTestClient(t) | ||
| head, err := c.LatestBlock(tests.Context(t)) | ||
| require.NoError(t, err) | ||
| require.True(t, head.IsValid()) |
There was a problem hiding this comment.
We should also test that chain info is updated
| return c | ||
| } | ||
|
|
||
| func TestMultiNodeClient_LatestBlock(t *testing.T) { |
There was a problem hiding this comment.
It woulbe be nice to add more coverage to verify that OnNewHead and OnNewFinalizedHead properly treats HealthCheckRequests and respects closure of requestCh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: https://smartcontract-it.atlassian.net/browse/BCFR-1071
Most of the code in the Solana MultiNodeClient can be reused by all chain integrations. This PR extracts all of the chain-agnostic client code through making a generic MultiNodeAdaptor. This will further extract functionality into the MultiNode and reduce new integration cost.
Generic MultiNodeAdaptor:
The the following methods can all be chain-agnostic and extracted:
All other client methods will still be implemented on the chain specific side including: