Refactor: Cleanup related to blue/green versions support [NONEVM-1114] #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues with refactor started in #414, #418, #432, #437, #442 & #454
This PR does a few unrelated small fixes here and there, I recommend reviewers look at it commit-by-commit. I've made each commit its own fix, with a one-liner title explaining the idea.
However, here's the list of changes with some additional info:
config
account to all methods that did not have them. This will allow us to configure the routing layer in each method, so we can do blue/green upgrades and shift traffic between versions.TimestampedPackedU224
, as that is an interface struct for us (meaning users have to send it in) so it's not versioned, and that could have leaked its implementation across versions. It was dead code anyway, so it was easy to remove.MAX_ORACLES
constant was already explicitly added to the IDL, so I moved it out of the versioned module, as it is thus part of our interface.use crate::v1::...
, thus making it break if we ever copy-paste that into av2
module. Now, they justuse super::...
, making it explicitly contained within their own module even if we copy-paste.