Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1894] add logstream flushing to default ccip cleanup #1570

Merged
merged 2 commits into from
Dec 11, 2024
Merged

[TT-1894] add logstream flushing to default ccip cleanup #1570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
effcb0b
add logstream flushing to default ccip cleanup
Tofel Dec 11, 2024
387ae23
dump logs only on test failure or test_log_collect=true
Tofel Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions integration-tests/ccip-tests/testsetups/ccip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import (
"github.com/smartcontractkit/chainlink-testing-framework/lib/k8s/config"
"github.com/smartcontractkit/chainlink-testing-framework/lib/k8s/environment"
"github.com/smartcontractkit/chainlink-testing-framework/lib/networks"
"github.com/smartcontractkit/chainlink-testing-framework/lib/utils/osutil"
"github.com/smartcontractkit/chainlink-testing-framework/lib/utils/testcontext"

integrationactions "github.com/smartcontractkit/chainlink/integration-tests/actions"
Expand Down Expand Up @@ -1386,6 +1387,10 @@ func (o *CCIPTestSetUpOutputs) CreateEnvironment(
t.Cleanup(func() {
if configureCLNode {
if ccipEnv.LocalCluster != nil {
if t.Failed() || (ccipEnv.LocalCluster.TestConfig.GetLoggingConfig() != nil && ccipEnv.LocalCluster.TestConfig.GetLoggingConfig().TestLogCollect != nil && *ccipEnv.LocalCluster.TestConfig.GetLoggingConfig().TestLogCollect) {
flushClLogs(*lggr, ccipEnv.LocalCluster)
}

err := ccipEnv.LocalCluster.Terminate()
require.NoError(t, err, "Local cluster termination shouldn't fail")
require.NoError(t, o.Reporter.SendReport(t, namespace, false), "Aggregating and sending report shouldn't fail")
Expand All @@ -1406,6 +1411,24 @@ func (o *CCIPTestSetUpOutputs) CreateEnvironment(
return chainByChainID
}

func flushClLogs(l zerolog.Logger, testEnv *test_env.CLClusterTestEnv) {
l.Info().Msg("Shutting down LogStream")
logPath, err := osutil.GetAbsoluteFolderPath("logs")
if err == nil {
l.Info().Str("Absolute path", logPath).Msg("LogStream logs folder location")
}

l.Info().Msg("Flushing LogStream logs")
// we can't do much if this fails, so we just log the error in LogStream
if err := testEnv.LogStream.FlushAndShutdown(); err != nil {
l.Error().Err(err).Msg("Error flushing and shutting down LogStream")
}
testEnv.LogStream.PrintLogTargetsLocations()
testEnv.LogStream.SaveLogLocationInTestSummary()

l.Info().Msg("Finished shutting down LogStream")
}

func createEnvironmentConfig(t *testing.T, envName string, testConfig *CCIPTestConfig, reportPath string) *environment.Config {
envConfig := &environment.Config{
NamespacePrefix: envName,
Expand Down
Loading