Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted manifest to single list of files #317

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

dogversioning
Copy link
Contributor

This PR makes the following changes:

  • Manifest list of files is now a single list, and finds the appropriate running mechanism via file extension
    • The old file lists are deprecated, but will still work for older studies
  • TOML configuration-driven table construction is now called a workflow

Checklist

  • Consider if documentation in docs/ needs to be updated
    • If you've changed the structure of a table, you may need to run generate-md
    • If you've added/removed core study fields that not in US Core, update our list of those in core-study-details.md
  • Consider if tests should be added
  • Update template repo if there are changes to study configuration in manifest.toml

Copy link

github-actions bot commented Nov 18, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2295 2287 100% 90% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cumulus_library/actions/builder.py 100% 🟢
cumulus_library/builders/protected_table_builder.py 100% 🟢
cumulus_library/cli.py 100% 🟢
cumulus_library/enums.py 100% 🟢
cumulus_library/study_manifest.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 7590dca by action🐍

Copy link
Contributor

@mikix mikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

cumulus_library/actions/builder.py Outdated Show resolved Hide resolved
cumulus_library/builders/protected_table_builder.py Outdated Show resolved Hide resolved
cumulus_library/study_manifest.py Outdated Show resolved Hide resolved
@dogversioning dogversioning merged commit e0c0728 into main Nov 19, 2024
3 checks passed
@dogversioning dogversioning deleted the mg/file_list branch November 19, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants