Add logo via iframe #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netsettler
changed the base branch from
master
to
kmp_better_section_organization
netsettler
changed the base branch from
kmp_better_section_organization
to
master
Pull Request Test Coverage Report for Build 5871956784
💛 - Coveralls |
willronchetti
approved these changes
Aug 18, 2023
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "submitr" | |||
| version = "0.3.3" | |||
| version = "0.3.3.2b2" # to become "0.3.4" | |||
There was a problem hiding this comment.
Since its a pure documentation change is it worth a version/changelog entry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This arranges for the logo to be done in an iframe, where the iframe just points to a static HTML file that arranges images in the way I want. I tried doing it without the iframe, but there's something about the way Sphinx sets up the navigation pane that makes it hard to get the positioning right. It may be they have some CSS style sheet that was thwarting me. But iframes block all of that.
This only fixes the issue in the ReadTheDocs code. I had to leave my other banner for the README.rst because I can't (yet) find a way to make that let me insert RAW HTML. The
.rstit allows is much more primitive than what ReadTheDocs allows.Reviewers can test the look by getting the repo and doing
make preview-locally.