Added interceptor's #674
Merged
Added interceptor's #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lways return. If there are 4 path pattern's and all of them are regex, then there was a bug that only the first one was checked. if that one failed then all the other ones where skipped. this fixes that.
…l-checked Fix regexp path patern not all checked
…ionDuration where not set to Duration.zero. And thus the default dustion of 300 milliseconds was used Add the option to pass transitionDuration, ans reverseTransitionDuration to beamPage. Fixed an issue where the duration of BeamPageType.noTransition was not zero.
…-general-improvements Added interceptor feature and general improvements
…-general-improvements Fixed linter issue
slovnicki
reviewed
Aug 5, 2024
|
Done ✅ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #674 +/- ##
==========================================
- Coverage 97.08% 93.45% -3.63%
==========================================
Files 14 16 +2
Lines 893 948 +55
==========================================
+ Hits 867 886 +19
- Misses 26 62 +36 ☔ View full report in Codecov by Sentry. |
slovnicki
reviewed
Aug 7, 2024
slovnicki
reviewed
Aug 7, 2024
slovnicki
reviewed
Aug 7, 2024
slovnicki
reviewed
Aug 7, 2024
slovnicki
reviewed
Aug 7, 2024
slovnicki
reviewed
Aug 7, 2024
slovnicki
reviewed
Aug 7, 2024
slovnicki
reviewed
Aug 7, 2024
slovnicki
reviewed
Aug 7, 2024
stan-at-work
approved these changes
Sep 20, 2024
Sten435
pushed a commit
to stan-at-work/beamer
that referenced
this pull request
Oct 8, 2024
Sten435
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BeamInterceptor and fixed a BeamPage.noTransition issue and general improvements