Correct handling of new URI API (fixes Deep Link Handling) #660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix #654 by correcting the usages of
uri.toString()
withuri.path
.The first commit would technically be sufficient to fix the issue, however, I would strongly recommend to also consider pulling in the second commit as it migrates some of the internal usages to the more appropriate URI API to prevent future mistakes while handling paths.
I also added additional tests to prevent future regressions of this type and tried to restore the behavior as close as possible as it was before bfe7ce3.