Spreadsheet increase inputsize #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lement in this context
…ng -> the save button needs to be visible
… 502 before merge.
poef
reviewed
Jan 21, 2025
www/assets/js/spreadsheet.js
Outdated
| let columnDef = getColumnDefinition(el) | ||
| let row = getRow(el) | ||
| selector.innerHTML = '' | ||
| selector.style.top = Math.max(2, (rect.top - offset.top))+'px' | ||
| selector.style.left = (rect.left - offset.left)+'px' | ||
| selector.style.width = rect.width+'px' | ||
| selector.style.width = Math.max(300, (rect.width))+'px' |
There was a problem hiding this comment.
Do Math.min(spreadsheetSize.width, Math.max(300, rect.width)+'px'
or Math.clamp if that exists
poef
reviewed
Jan 21, 2025
www/assets/js/spreadsheet.js
Outdated
| const spreadsheetSize = spreadsheetElement.getBoundingClientRect(); | ||
| const boxWidth = spreadsheetSize.width/1.618 // golden ratio | ||
| const iconSize = 60 | ||
| const standardBoxWidth = 300 + iconSize |
There was a problem hiding this comment.
add a const minSize = 300 and use that everywhere
poef
reviewed
Jan 21, 2025
| selector.style.left = (extraPadding) +'px' | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Please extra code above to a separate function, e.g. calculateOptimalPosition
poef
reviewed
Jan 21, 2025
www/assets/js/spreadsheet.js
Outdated
| } | ||
| } else { | ||
|
|
||
| selector.style.height = 'fit-content' | ||
| selector.style.overflow = 'visible' | ||
| } |
There was a problem hiding this comment.
If each branch of if/else has the same code, extract it outside the if/else branches
In addition: maybe add the height and top calculation to the earlier calculateOptimalPosition code and return a new object with { top, left, width, height } properties
Also set a maximum height to spreadsheet.height - select.style.top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the notes at line 498 and 502 in spreadsheet.js. And explain to Govert why that code is there please.