Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition when stopping before spinner fully built #3

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Fix race condition when stopping before spinner fully built #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spinner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,10 @@ func (s *Spinner) StartWithSpeed(message string, speed time.Duration) error {

s.message = message
s.createFrames()
s.ticker = time.NewTicker(speed)
// Start the animation in background
go func() {
s.running = true
s.ticker = time.NewTicker(speed)

for range s.ticker.C {
s.Render()
Expand Down