Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typehints, missing documentation & formatting #6

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

lfse-slafleur
Copy link
Contributor

The following changes are proposed:

  • Fix formatting of the file by changing all tabs to just 4 spaces. Previously, tabs and spaces were both used.
  • Add typehints where possible. Either fix or suppress issues.
  • Add documentation.

@sloisel
Copy link
Owner

sloisel commented Jul 23, 2024

I have yet to put in github automation for my unit tests, can you just tell me if you unit tested this?

@sloisel sloisel closed this Jul 25, 2024
@sloisel sloisel reopened this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@sloisel sloisel merged commit 78898ec into sloisel:master Jul 25, 2024
3 checks passed
@lfse-slafleur
Copy link
Contributor Author

I have yet to put in github automation for my unit tests, can you just tell me if you unit tested this?

Apologies for a later reply! Yes, I had run each of the tests.

Thanks for merging! Hope it helps :D

@lfse-slafleur lfse-slafleur deleted the types_docs_small_fix branch July 25, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants