Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreachable code warnings in Firefox 40. #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix unreachable code warnings in Firefox 40. #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/numeric.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,10 +358,10 @@ numeric.mapreduce = function mapreduce(body,init) {
numeric.mapreduce2 = function mapreduce2(body,setup) {
return Function('x',
'var n = x.length;\n'+
'var i,xi;\n'+setup+';\n'+
'var i,xi;\n'+setup+'\n'+
'for(i=n-1;i!==-1;--i) { \n'+
' xi = x[i];\n'+
' '+body+';\n'+
' '+body+'\n'+
'}\n'+
'return accum;'
);
Expand Down Expand Up @@ -663,7 +663,7 @@ numeric.mapreducers = {
prod: ['accum *= xi;','var accum = 1;'],
norm2Squared: ['accum += xi*xi;','var accum = 0;'],
norminf: ['accum = max(accum,abs(xi));','var accum = 0, max = Math.max, abs = Math.abs;'],
norm1: ['accum += abs(xi)','var accum = 0, abs = Math.abs;'],
norm1: ['accum += abs(xi);','var accum = 0, abs = Math.abs;'],
sup: ['accum = max(accum,xi);','var accum = -Infinity, max = Math.max;'],
inf: ['accum = min(accum,xi);','var accum = Infinity, min = Math.min;']
};
Expand Down Expand Up @@ -763,7 +763,7 @@ numeric.mapreducers = {
o[1]+
'if(typeof x !== "object") {'+
' xi = x;\n'+
o[0]+';\n'+
o[0]+'\n'+
' return accum;\n'+
'}'+
'if(typeof s === "undefined") s = numeric.dim(x);\n'+
Expand All @@ -773,7 +773,7 @@ numeric.mapreducers = {
'var n = x.length, i;\n'+
'for(i=n-1;i!==-1;--i) {\n'+
' xi = arguments.callee(x[i]);\n'+
o[0]+';\n'+
o[0]+'\n'+
'}\n'+
'return accum;\n');
}
Expand Down Expand Up @@ -1102,15 +1102,15 @@ numeric.Tunop = function Tunop(r,c,s) {
'var x = this;\n'+
s+'\n'+
'if(x.y) {'+
' '+c+';\n'+
' '+c+'\n'+
'}\n'+
r+';\n'
r+'\n'
);
}

numeric.T.prototype.exp = numeric.Tunop(
'return new numeric.T(ex)',
'return new numeric.T(mul(cos(x.y),ex),mul(sin(x.y),ex))',
'return new numeric.T(ex);',
'return new numeric.T(mul(cos(x.y),ex),mul(sin(x.y),ex));',
'var ex = numeric.exp(x.x), cos = numeric.cos, sin = numeric.sin, mul = numeric.mul;');
numeric.T.prototype.conj = numeric.Tunop(
'return new numeric.T(x.x);',
Expand All @@ -1120,10 +1120,10 @@ numeric.T.prototype.neg = numeric.Tunop(
'return new numeric.T(neg(x.x),neg(x.y));',
'var neg = numeric.neg;');
numeric.T.prototype.sin = numeric.Tunop(
'return new numeric.T(numeric.sin(x.x))',
'return new numeric.T(numeric.sin(x.x));',
'return x.exp().sub(x.neg().exp()).div(new numeric.T(0,2));');
numeric.T.prototype.cos = numeric.Tunop(
'return new numeric.T(numeric.cos(x.x))',
'return new numeric.T(numeric.cos(x.x));',
'return x.exp().add(x.neg().exp()).div(2);');
numeric.T.prototype.abs = numeric.Tunop(
'return new numeric.T(numeric.abs(x.x));',
Expand Down