Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update min version for scikit-learn #198

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

amirhessam88
Copy link
Member

@amirhessam88 amirhessam88 commented Jul 25, 2024

Description

  • Previously, we have fixed the y_score parameter name in precision-recall metric; however, that fix was introduced in scikit-learn v1.5 (docs); This will be removed in v1.7 no matter what; so, even better we stick to it from now on.
  • API Change metrics.precision_recall_curve deprecated the keyword argument probas_pred in favor of y_score. probas_pred will be removed in version 1.7. #28092 by Adam Li.

Resolves: #issue-number-here

Pull Request Checklist

  • Added tests for added or changed code.
  • Added documentation for changed code.

@amirhessam88 amirhessam88 added the bug Something isn't working label Jul 25, 2024
@amirhessam88 amirhessam88 self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (6eb4a99) to head (21287d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          24       24           
  Lines        1907     1907           
  Branches      211      211           
=======================================
  Hits         1857     1857           
  Misses         24       24           
  Partials       26       26           
Flag Coverage Δ
unittests 97.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amirhessam88 amirhessam88 merged commit bf2986c into master Jul 25, 2024
7 checks passed
@amirhessam88 amirhessam88 deleted the amir/sklearn-min-version branch July 25, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant