Functional version of code, changes necessary for neatness

tests/ci/check_so_interface.py

@@ -3,12 +3,38 @@
 # specified here: https://www.overleaf.com/project/5e837cac9659910001e5f71e
 # could move this to a file
 #to complete: work on functions and arguments to check file and spec_args dictionary
+
+#Files that need to be checked: smurf_tune, smurf_command, smurf_util, smurf_noise, smurf_iv
+#python/pysmurf/client/util/smurf_util.py
+#python/pysmurf/client/command/smurf_command.py
+#python/pysmurf/client/debug/smurf_noise.py
+#python/pysmurf/client/debug/smurf_iv.py
 interface = {
     "python/pysmurf/client/tune/smurf_tune.py": {  # file
         "SmurfTuneMixin": {                        # class
             "find_freq": [],                       # function and args
         }
     },
+    "python/pysmurf/client/command/smurf_command.py": {
+        "SmurfCommandMixin": {
+            "set_stream_enable": []
+        }
+    },
+    "python/pysmurf/client/util/smurf_util.py": {
+        "SmurfUtilMixin": {
+            "which_on": []
+        }
+    },
+    "python/pysmurf/client/debug/smurf_iv.py": {
+        "SmurfIVMixin": {
+            "run_iv": []
+        }
+    },
+    "python/pysmurf/client/debug/smurf_noise.py": {
+        "SmurfNoiseMixin": {
+            "take_noise_psd" : []
+        }
+    }
 }
 
 spec_args = {
@@ -104,49 +130,50 @@
     for node in ast.walk(frozen):
         if isinstance(node, ast.FunctionDef) and node.name in spec_args.keys():
             freeze.update({node.name: node})
+print("FROZEN")
 print(freeze.items())
 """
 *** ==> I found this function in smurf_tune.py
 frozen functions list:
 
 SETUP FUNCTIONS
 setup
-set_amplifier_bias
-set_cryo_card_ps_en
-which_on
-band_off
-channel_off
+set_amplifier_bias #smurf_command
+set_cryo_card_ps_en #smurf_command
+which_on #smurf_util
+band_off #smurf_util
+channel_off #smurf_util
 
 TUNING FUNCTIONS
 full_band_resp ***
 find_freq ***
 setup_notches ***
-run_serial_gradient_descent
-run_serial_eta_scan
+run_serial_gradient_descent #smurf_command
+run_serial_eta_scan #smurf_command
 plot_tune_summary ***
 tracking_setup ***
-set_amplitude_scale_array
+set_amplitude_scale_array #smurf_command
 
 TES/FLUX RAMP FUNCTIONS
-set_tes_bias_bipolar_array
-set_tes_bias_high_current
-set_tes_bias_low_current
-set_mode_dc
-set_mode_ac
+set_tes_bias_bipolar_array #smurf_util
+set_tes_bias_high_current #smurf_util
+set_tes_bias_low_current #smurft_util
+set_mode_dc #smurf_util
+set_mode_ac #smurf_util
 flux_ramp_setup ***
 
 DATA ACQUISITION FUNCTIONS
-set_stream_enable
-take_stream_data
-take_noise_psd
-stream_data_on
-stream_data_off
-read_stream_data
-set_downsample_filter
+set_stream_enable #smurf_command
+take_stream_data #smurf_util
+take_noise_psd #smurf_noise
+stream_data_on #smurf_util
+stream_data_off #surf_util
+read_stream_data #smurf_util
+set_downsample_filter #smurf_util
 
 IV FUNCTIONS
-run_iv
-analyze_iv
+run_iv #smurf_iv
+analyze_iv #smurf_iv
 
 DATA OUTPUTS TO DISK
 tune files generated when new resonators are found
@@ -155,14 +182,18 @@
 iv_files - generated by run_iv"
 
 """
-def compare_args(found, spec_args):
+def compare_args(found, freeze):
+    #print(freeze.values())
     for func_name, func_node in found.items():
-        if func_name not in spec_args:
+        if func_name not in freeze:
             print(func_name + " not in specified functions")
             continue
-
-        spec_func = spec_args[func_name]
-
+
+        spec_func = freeze[func_name]
+        #print(freeze[func_name])
+        if spec_func == []:
+            print("waht")
+
         # Handle the case where spec_func is a list
         if isinstance(spec_func, list):
             if len(spec_func) == 0:
@@ -172,12 +203,13 @@ def compare_args(found, spec_args):
 
         # Extract arguments from the AST node
         found_args = [arg.arg for arg in func_node.args.args]
+        #print(found_args)
         found_defaults = [ast.unparse(d) if d else None for d in func_node.args.defaults]
+        #print(found_defaults)
 
         # Extract arguments from the spec function
-        spec_sig = ast.parse(f"def {func_name}{ast.get_source_segment(spec_func, spec_func.args)}:pass").body[0]
-        spec_args_list = [arg.arg for arg in spec_sig.args.args]
-        spec_defaults = [ast.unparse(d) if d else None for d in spec_sig.args.defaults]
+        spec_args_list = [arg.arg for arg in spec_func.args.args]
+        spec_defaults = [ast.unparse(d) if d else None for d in spec_func.args.defaults]
 
         # Compare arguments
         if found_args != spec_args_list:
@@ -197,7 +229,6 @@ def compare_args(found, spec_args):
 
 if __name__ == "__main__":   #if this is the main thing being run
     for fname, spec in interface.items():   #loop over file names "fname" as keys and "spec" as values in dictionary called "interface"
-        print(interface.items())
         with open(fname, 'r') as fh:   #opens file "fname", in read mode 'r', to be used in code as "fh"
             tree = ast.parse(fh.read()) #parsing contents of file into abstract syntax tree
             notfound = []
@@ -209,11 +240,11 @@ def compare_args(found, spec_args):
         for key in spec_args:
             if key not in found:
                 notfound.append(key)          
-        print("FOUND:")
-        print(found.keys())
-        print("NOT FOUND:")
-        print(notfound)
+        #print("FOUND:")
+        #print(found.items())
+        #print("NOT FOUND:")
+        #print(notfound)
         #compare arguments
-        assert compare_args(found, spec_args)
+        assert compare_args(found, freeze)
         #print(ast.dump(found.get('find_freq')))
 pass