Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-19.0: use slackhq/[email protected] #575

Merged
merged 16 commits into from
Jan 10, 2025
Merged

slack-19.0: use slackhq/[email protected] #575

merged 16 commits into from
Jan 10, 2025

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Dec 17, 2024 •
edited
Loading

Description

This PR updates slackhq/vitess-addons to the v0.19.7 tag

Also the source-name for vtops problems was simplified to be vtorc-POOL-ENV vs. the longer/redundant vtorc-bedrock-POOL-ENV and a conditional to pass tablet alias to vtops-vtorc was added

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt requested a review from a team as a code owner December 17, 2024 15:49
@github-actions github-actions bot added this to the v19.0.7 milestone Dec 17, 2024
@timvaillancourt
simplify vtorc service name
c4e6b0a 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
simplify vtorc service name 2
6f950a3 
Signed-off-by: Tim Vaillancourt <[email protected]>
ejortegau
ejortegau previously approved these changes Dec 18, 2024
View reviewed changes
@timvaillancourt timvaillancourt requested review from ejortegau and a team December 18, 2024 16:45
@timvaillancourt
pre-test v0.19.6 tag w/commit
5bc7174 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
go mod tidy
56d00c9 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt changed the title slack-19.0: use slackhq/[email protected] slack-19.0: use slackhq/[email protected] Dec 18, 2024
timvaillancourt
timvaillancourt commented Dec 18, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@timvaillancourt
revert cond
ec9bd77 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
goimports
d888629 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
update
c625001 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
update tag
36dff2e 
Signed-off-by: Tim Vaillancourt <[email protected]>
tanjinx
tanjinx previously approved these changes Jan 9, 2025
View reviewed changes
tanjinx
tanjinx previously approved these changes Jan 9, 2025
View reviewed changes
@timvaillancourt
fix e2e output
3977bb6 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt changed the title slack-19.0: use slackhq/[email protected] slack-19.0: use slackhq/[email protected] Jan 10, 2025
@timvaillancourt
v0.19.7
0008ae7 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
Copy link
Member Author

Updated to v0.19.7 to fix this e2e test failure: https://slack-github.com/slack/vtops/pull/1589

@timvaillancourt
fix CI
07ed7fb 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt merged commit bb6271b into slack-19.0 Jan 10, 2025
163 of 165 checks passed
@timvaillancourt timvaillancourt deleted the addons-v0.19.5.slack-19.0 branch January 10, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx approved these changes

@ejortegau ejortegau Awaiting requested review from ejortegau

Assignees
No one assigned
Labels
v19
Projects
None yet
Milestone
v19.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@timvaillancourt @ejortegau @tanjinx