Add a complex type assignment check test to DaggerIssuesDetectorTest (#…

…142) This just bolts down some stuff we were questioning when running this lint internally.
slackhq · Oct 3, 2023 · 961a1fe · 961a1fe
1 parent b1443e5
commit 961a1fe
Showing 1 changed file with 19 additions and 3 deletions.
diff --git a/slack-lint-checks/src/test/java/slack/lint/DaggerIssuesDetectorTest.kt b/slack-lint-checks/src/test/java/slack/lint/DaggerIssuesDetectorTest.kt
@@ -155,18 +155,31 @@ class DaggerIssuesDetectorTest : BaseSlackLintTest() {
         javaxInjectStubs,
         daggerStubs,
         kotlin(
+            "src/foo/TestModule.kt",
             """
                   package foo
                   import javax.inject.Qualifier
                   import dagger.Binds
                   import dagger.Module
 
+                  sealed interface ItemDetail {
+                    object DetailTypeA : ItemDetail
+                  }
+
+                  interface ItemMapper<T : ItemDetail>
+
+                  class DetailTypeAItemMapper : ItemMapper<ItemDetail.DetailTypeA>
+
                   @Module
                   interface MyModule {
                     @Binds fun validBind(real: Int): Number
                     @Binds fun validBind(real: Boolean): Comparable<Boolean>
                     @Binds fun invalidBind(real: Long): String
                     @Binds fun invalidBind(real: Long): Comparable<Boolean>
+
+                    @Binds fun validComplexBinding(real: DetailTypeAItemMapper): ItemMapper<out ItemDetail>
+                    @Binds fun validComplexBinding2(real: DetailTypeAItemMapper): ItemMapper<*>
+                    @Binds fun invalidComplexBinding(real: DetailTypeAItemMapper): ItemMapper<ItemDetail>
                   }
                 """
           )
@@ -176,13 +189,16 @@ class DaggerIssuesDetectorTest : BaseSlackLintTest() {
       .run()
       .expect(
         """
-        src/foo/MyModule.kt:10: Error: @Binds function parameters must be type-assignable to their return types. [BindsTypeMismatch]
+        src/foo/TestModule.kt:18: Error: @Binds function parameters must be type-assignable to their return types. [BindsTypeMismatch]
           @Binds fun invalidBind(real: Long): String
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-        src/foo/MyModule.kt:11: Error: @Binds function parameters must be type-assignable to their return types. [BindsTypeMismatch]
+        src/foo/TestModule.kt:19: Error: @Binds function parameters must be type-assignable to their return types. [BindsTypeMismatch]
           @Binds fun invalidBind(real: Long): Comparable<Boolean>
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-        2 errors, 0 warnings
+        src/foo/TestModule.kt:23: Error: @Binds function parameters must be type-assignable to their return types. [BindsTypeMismatch]
+          @Binds fun invalidComplexBinding(real: DetailTypeAItemMapper): ItemMapper<ItemDetail>
+          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+        3 errors, 0 warnings
         """
           .trimIndent()
       )