Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile support #736

Closed
wants to merge 9 commits into from
Closed

Conversation

SergeantSerk
Copy link

Hey all!

I felt the need to add a Dockerfile (and .dockerignore) to this repo seeing as how I'd want to run this on a Docker container where it can persist and restart with the host machine. Personally, this makes it so much easier than downloading the binary and creating a system service whereas a simple container can be loaded on the go.

Do note that with this Dockerfile, nebula-cert is not included, though that can be changed within the COPY command. Also, this uses the latest tag of golang for building and runtime, just to note for later if a stable release tag needs to be used if any.

Also, it would be ideal if some automated Dockerhub image publishing happens so users don't have to clone this repo and build image locally but instead, use something like docker pull slackhq/nebula.

I recommend trying this on different platforms too (macOS and Windows) just to ensure this works and doesn't break anything.

Tried with nebula lighthouse node deployed on Ubuntu 22.04.1 LTS Docker with current example configuration and Windows client (1 lighthouse and one client on local network).

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2022

CLA assistant check
All committers have signed the CLA.

@SergeantSerk
Copy link
Author

SergeantSerk commented Aug 27, 2022

I have just noticed that PR #68 also exists but not merged. While it may work, mine is more up-to-date, makes use of Makefile's bin-docker argument, is much smaller in terms of container footprint and doesn't need to deal with alpine.

@SergeantSerk
Copy link
Author

SergeantSerk commented Aug 27, 2022

Also tried with nebula lighthouse node deployed on a Linode instance Debian 9.13 Docker with current example configuration and Windows client (1 lighthouse and one client on the Internet). ✔️

@bitshop
Copy link
Contributor

bitshop commented Oct 2, 2022

This specifically uses the linux-amd64 build so I think it needs to pull proper file from build either for running platform or all platforms (so that it can be published to a repo and work with aarm64, etc).

Good work and idea.

@johnmaguire johnmaguire mentioned this pull request Dec 12, 2022
@johnmaguire
Copy link
Collaborator

If merged, this could close #25. I am soliciting feedback in #25 to try to understand Nebula users' goals in using Docker. I'd appreciate your use case - thanks!

@johnmaguire
Copy link
Collaborator

We're going to try to get #1037 merged in an upcoming release. Going to close this out. Thanks for the help!

@johnmaguire johnmaguire closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants