Multipath unsafe routes #1012
Closed
Multipath unsafe routes #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit on experimental concept to support ECMP routing.
When a multipath route is discovered, we can now make use of any ECMP gateway in the set. Sort by highest weight, with randomized equal-weight order and route via either the highest priority gateway with an active tunnel, or the first gateway if there are no tunnels yet.
|
While this was a working implementation, there are a couple of open questions about how we should treat same-weight routes. TCP connections would likely need to remain sticky to a tunnel/route (where possible), particularly if using NAT on the host that is forwarding to the unsafe network, if the route became unavailable, we could consider sending a reset back to force the client to start a new TCP session over the new path, but obviously there are also a lot of other corner cases. Secondarily, the feature was broken by #1004 and the use case for which I was experimenting with this became a bit too complex. Closing for now, we can revisit if there is a future need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds support for discovering weighted multipath routes from the system route table on linux.