-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added firewall.rules.hash metric #1010
Conversation
Added a FNV-1 hash of the firewall rules as a Prometheus value.
Thanks for the contribution! Before we can merge this, we need @britcey to sign the Salesforce Inc. Contributor License Agreement. |
Closes issue #1005 |
Thanks for the PR! My primary concern is that there is no direct correlation back to the log line. I think this could be resolved in two ways.
Ideally we would do both here but option 2 is more difficult so lets add the FNV hash to the log lines. |
Option 2 would also increase cardinality, creating a new timeseries every time that label changed, so including the FNV hash in the log is the way to go, for sure. I'll make that happen. |
This work for the logs? Startup:
after a reload:
|
Let go-metrics cast the uint32 to a int64, so it won't be lossy when it eventually emits a float64 Prometheus metric.
Anything needed here? |
@britcey Thanks for your contribution! |
Added a FNV-1 hash of the firewall rules as a Prometheus value.